Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naming Convention Violations for Variables in RosPackageTemplate #42

Open
neriyashul opened this issue Jul 5, 2023 · 0 comments
Open

Comments

@neriyashul
Copy link

neriyashul commented Jul 5, 2023

The member variables in the RosPackageTemplate package of this repository are not following the recommended naming conventions outlined in the ROS C++ Style Guide.

According to ROS style guide, member variables should be named using under_scored, while in the current implementation, camelCase is used.

For example, in the RosPackageTemplate class:

- serviceServer_
- subscriberTopic_
- nodeHandle_

I have no problem making a pull request to address this issue if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant