Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignored workspaces not working as intended #214

Open
ghost opened this issue Jun 3, 2023 · 3 comments
Open

ignored workspaces not working as intended #214

ghost opened this issue Jun 3, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@ghost
Copy link

ghost commented Jun 3, 2023

I added my name to the list of ignored workspaces so it doesn't show up in discord.
After doing so I noticed that all workspaces and repositories are ignored. This seems to be due to the fact that my username in Windows is my first name which is exactly what I added to vscord.ignore.workspaces. The ignore functionality seems to work perfectly fine if I remove my name from the ignore list. Is there any way this can be fixed?

@xhayper xhayper added the bug Something isn't working label Jun 3, 2023
@xhayper
Copy link
Collaborator

xhayper commented Jun 3, 2023

How are we gonna approach this? do we use hard code in OS specific username / filesystem structure? or make it so the path is relative instead of absolute?

@ghost
Copy link
Author

ghost commented Jun 4, 2023

I think allowing the user to switch from relative path to absolute path for workspace detection might be a good solution.

@xhayper
Copy link
Collaborator

xhayper commented Jun 4, 2023

I think that relative path as a default is the best way moving foward

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant