Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio Video recording #86

Open
mits87 opened this issue Jan 15, 2017 · 1 comment
Open

Audio Video recording #86

mits87 opened this issue Jan 15, 2017 · 1 comment

Comments

@mits87
Copy link
Contributor

mits87 commented Jan 15, 2017

Hello,

I saw the issue: #66
and I saw the video_recorder.rb

In line 97 is a small bug because probably variable @Devices should be 1 line below:

"-s #{dimensions}",
"-f x11grab",
"-i :#{@display}",
@devices,
group_of_pic_size_option,
"-vcodec #{@codec}",

could you check it and fix?
Thank you!

@jontonsoup
Copy link

this is for sure a bug. It mixes the order of input and output streams. Audio doesn't work because of this. I think its more complicated than the proposed solution. I forked it / hard coded it for my use case as this repo seems dead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants