This repository has been archived by the owner on Feb 19, 2024. It is now read-only.
feat(infra): introduce public IP to node info #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suyuee
force-pushed
the
publicip
branch
2 times, most recently
from
1abe215
to
310f715
Compare
ccding
reviewed
Oct 13, 2023
ccding
reviewed
Oct 16, 2023
ccding
reviewed
Oct 16, 2023
xiang90
reviewed
Oct 16, 2023
xiang90
reviewed
Oct 16, 2023
| @@ -40,6 +40,7 @@ const ( | |||
| WorkingNamespace = "kube-system" | |||
| RavenGlobalConfig = "raven-cfg" | |||
| LabelCurrentGatewayEndpoints = "raven.openyurt.io/endpoints-name" | |||
| LabelLeptonSatellitePublicIP = "lepton.ai/provider-public-ip" | |||
There was a problem hiding this comment.
maybe still use the openyurt namespace?
There was a problem hiding this comment.
we already have this label on our edge nodes, need to rename it for all our edge nodes
ccding
reviewed
Oct 23, 2023
| @@ -177,9 +177,10 @@ func (r *ReconcileGateway) Reconcile(ctx context.Context, req reconcile.Request) | |||
| err = fmt.Errorf("unable to list nodes: %s", err) | |||
| return reconcile.Result{}, err | |||
| } | |||
| klog.V(1).Info(Format("list gateway %d node %v", len(nodeList.Items), nodeList.Items)) | |||
| klog.V(1).Info(Format("list gateway %d", len(nodeList.Items))) | |||
There was a problem hiding this comment.
why do we change this? I thought we should minimize the diff to make future merge/rebase easier
There was a problem hiding this comment.
nodeList.Items are huge... the status/annotations etc. although we want to make it easier to merge, another bigger goal (I think) is to make it suitable for production deployment.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raven make assumptions that our setup doesn't fit into
I would say our setup is very special, therefore I can image it will be hard to convince them accept some of k our PRs, so we need to take over the codebase and close the gaps. This is the first among several. btw
make manifestscreates a bunch of unrelated stuffFor this PR, the goal is to enable satellite nodes to establish vxlan connections by introducing node public IPs. The context is that, Raven controller controls a CRD called Gateway, and it populates node info into NodeInfo CRD. Right now, it only takes the node internal IP.
Raven assumes: among 1 edge/satellite node group, nodes can communicate with each other and establish vxlan connections via their private IP addresses directly without any additional techniques and that they show up in the cluster with their private IP addresses
Our setup: nodes show up in the cluster with assigned IP ranges, so we can't easily just directly use their IPs to establish vxlan connections
cc @xiang90 @gyuho @ccding