Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cargo.lock #2881

Open
sabify opened this issue Aug 26, 2024 · 1 comment
Open

Cargo.lock #2881

sabify opened this issue Aug 26, 2024 · 1 comment

Comments

@sabify
Copy link
Contributor

sabify commented Aug 26, 2024

By introducing cargo lockfile to the project and examples, we will:

  • Make Dependabot work. As you may notice, we don't have any PRs from Dependabot even though we had some dependency updates.
  • Have the best working snapshot via the lockfile. We've seen that some dependencies like wasm-bindgen do not strictly follow semver semantics and somehow introduce breaking changes in patches. (cargo command with --locked feature switch can put us in a working snapshot)
@gbj
Copy link
Collaborator

gbj commented Aug 28, 2024

For some added context, the guidance on including lockfiles in libraries has changed during the lifetime of this project, from "don't include lockfiles for libraries" to "maybe include lockfiles for libraries."

I think this is probably a good suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants