Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional param segments unrecognized by path! macro in 0.7 beta 2 #2896

Closed
Houski opened this issue Aug 30, 2024 · 3 comments
Closed

Optional param segments unrecognized by path! macro in 0.7 beta 2 #2896

Houski opened this issue Aug 30, 2024 · 3 comments
Milestone

Comments

@Houski
Copy link
Contributor

Houski commented Aug 30, 2024

Something I noticed converting from 0.6 -> 0.7

path!("/property/:country_abbreviation?/:province_abbreviation?/:city?/:community?")

This will return the error of " Invalid param segment: country_abbreviation? ".

So missing routing parity to 0.6 with the path! macro.

@gbj gbj added this to the 0.7 milestone Aug 31, 2024
@gbj
Copy link
Collaborator

gbj commented Aug 31, 2024

Oh yeah I have not implemented optional param segments at all, not just in the macro. Thanks for the reminder.

@rakshith-ravi
Copy link
Collaborator

I think I might be able to take this up

@rakshith-ravi
Copy link
Collaborator

one quick look later

Is this still necessary, especially since we have wildcard segments? Cuz I'm not sure how the implementation will differ from how wildcard segments work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants