Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The node attribue scratchpad_state is not in sway #45

Open
sophacles opened this issue Jan 5, 2023 · 2 comments
Open

The node attribue scratchpad_state is not in sway #45

sophacles opened this issue Jan 5, 2023 · 2 comments

Comments

@sophacles
Copy link
Contributor

The attr scratchpad_state is not present in ipc output of sway. It's unclear if it ever was there, but the last occurance of the string scratchpad_state in the sway repo was removed in this commit:

swaywm/sway@a6bc46e

The attribute should probably be gated the sway feature flag.

@sophacles
Copy link
Contributor Author

@leshow Im working on getting a project I have to work with sway as well as i3, I'm fine putting up a PR for this. I presume similar things may be discovered over the next few days as I work on it. Would you prefer if I make this ticket a general "sway differences" ticket or do a separate one (and pr) for each?

(I'm happy to do this work either way though :) )

@leshow
Copy link
Owner

leshow commented Jan 6, 2023

Hey! Yes, I'd prefer it all in one PR. Feature gating the sway fields sounds good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants