Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two types of "service" in discoverymgr #116

Open
tiokim opened this issue Jul 29, 2020 · 2 comments
Open

Two types of "service" in discoverymgr #116

tiokim opened this issue Jul 29, 2020 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@tiokim
Copy link
Contributor

tiokim commented Jul 29, 2020

I think there are two types of "service" in discoverymgr (discovery.go, wrapper.go, etc) which can confuse people.

  1. Service for mDNS/DNS-SD

    • Variables related to Zeroconf such as serviceEntry
  2. Service for Edge App

    • Most variables such as ServiceList in OrchestrationInformation
@MoonkiHong
Copy link
Contributor

Thank you for this valuable report. We might need to clarify the true meaning of the current glossary, so that we can help visitors/developers to fully understand our code from code level.

@suresh-lc Any thoughts?

@MoonkiHong MoonkiHong added the enhancement New feature or request label Jul 29, 2020
@suresh-lc
Copy link
Contributor

Ya it looks as good thought and suggestion. Actually initial code of Home Edge was developed by SR-Korea and little part by SRIB. And as Open Source part, we haven't checked on these. Might be we can think of this as start and look into whole code for such variable naming conventions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants