-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Design Issues #946
Comments
Hey, @amazinernest. I'll like to work on this issue |
Hi @amazinernest can i please be assigned to this issue |
@amazinernest I can take on this issue as I have experience with UI/UX design and I am also a frontend developer. |
hello @amazinernest i'm a proficient This will be my first time contributing on this repo :) |
@amazinernes am a frontend end developer with experience in using frontend technologies. kindly assign me this task I would like to make it my first contribution to the starknet quest project. |
@amazinernest kindly assign me this task if it is still open for contribution. Am experienced in developing frontend application using React. |
@amazinernest Can I work on this? I already have experience working on Starknet Quest frontend |
Thanks @amazinernest I'll add this issue for the next OD hack that will happen next week ! If you want to do it you'll have priority, wait for next week to do it pls |
@fricoben Can I jump on this |
hi @amazinernest For this bottom padding issue, I’ll add spacing below the last card on mobile to match the top padding on the first card. This small change will give users a bit more breathing room at the end of the section, creating a cleaner, more balanced view. Once I’ve made the change, I’ll test it on different screen sizes to ensure it looks consistent across devices. |
Hi, I'm Josué Brenes and I'll be working on issue. I estimate this will take 1 day to complete. Solution for Padding Issue on MobileTo solve the issue of insufficient bottom padding for the last card in the "quests" section, the following approach can be implemented using React and TypeScript (TSX). The solution dynamically ensures that the last card gets extra padding to provide better visual spacing. Steps to Solve1. Use Conditional PaddingWe will check if the card being rendered is the last in the list. If so, additional padding or margin is applied to the card. 2. Utilize Tailwind CSS (or Custom CSS)The solution uses Code Implementationimport React from "react";
const QuestCard = ({ title, description }: { title: string; description: string }) => {
return (
<div className="bg-gray-800 text-white p-4 rounded-lg shadow-md">
<h3 className="text-lg font-bold">{title}</h3>
<p className="text-sm">{description}</p>
</div>
);
};
const QuestList = () => {
const quests = [
{ id: 1, title: "Nostra - LaFamiglia Rose", description: "Nostra" },
{ id: 2, title: "Another Quest", description: "Details" },
// Add more quests here
];
return (
<div className="space-y-4 p-4">
{quests.map((quest, index) => (
<div
key={quest.id}
className={`${index === quests.length - 1 ? "mb-8" : ""}`} // Extra margin for the last card
>
<QuestCard title={quest.title} description={quest.description} />
</div>
))}
</div>
);
};
export default QuestList; Explanation
Alternate CSS ApproachIf you are not using Tailwind CSS, you can add conditional CSS classes as shown below: TSX Code:<div
key={quest.id}
className={`quest-card ${index === quests.length - 1 ? "last-card" : ""}`}
>
<QuestCard title={quest.title} description={quest.description} />
</div> CSS Code:.quest-card {
margin-bottom: 1rem;
}
.quest-card.last-card {
margin-bottom: 2rem; /* Additional spacing for the last card */
} ResultThis solution ensures sufficient bottom spacing for the last card in a dynamically rendered list, improving the user experience on mobile devices. |
hi steps on approaching this issue |
@fricoben can i be assigned to this? |
@fricoben I'd like to handle this task |
Hey @fricoben can I hop on this one when the OD hack starts |
Bottom Padding
The section showing the cards at the end needs a little breathing space on mobile. Since there was a padding at the top section on the first card, I feel a padding below at the end of the last card should be also there as well
The text was updated successfully, but these errors were encountered: