-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build Wheels #106
Comments
@pastewka Is C++11 sufficient for everything we use? If not there are tricks to enable C++14 compliant compilers: https://cibuildwheel.readthedocs.io/en/stable/cpp_standards/ |
The C++ parts are very bare bones, C++11 should be sufficient. |
Done for MacOS and Linux in #107. Will leave this open until tested and as a reminder to add Windows support. |
Hey @jameskermode, Putting a comment here for the windows wheels. I am trying to install matscipy on windows. I think I am using MSVC compiler. When doing Not sure I understand correctly the error. Maybe the wheels does not work with MSVC and I should use GCC. |
OK thanks. This is the same error I get in GitHub Actions so at least it's consistent. |
There do seem to be some portability problems with our C++ code to Visual C++. Working on it in the windows-wheels branch, but iteration is a bit slow testing only via CI. |
The new windows wheel works great, but when I
|
I think this could be related to moving the location of the extension module @prs513rosewood |
Agreed, it looks related to that change. Can we fix or revert please? |
@ilyes319 Could you list your |
I investigated a bit more and the true error message is the following:
I looked into the DLL load failed error and the source could be either:
After looking at the dependencies of the compiled extension, it seems the second option is more likely, since it links to |
@ilyes319 The latest wheels should now work for windows. |
I'd like to setup cibuildwheel to build binary wheels using GitHub Actions that we can release on PyPI. This would also help with issues like #57 requesting support on a wider range of platforms. I've had good success doing this with f90wrap and quippy, and matscipy should be simpler as there's no Fortran (although there is C++, so #96 would still be valuable).
The text was updated successfully, but these errors were encountered: