Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vacancy test (and others?) use wrong bulk structure for low symmetry lattices #18

Open
bernstei opened this issue Apr 1, 2022 · 0 comments

Comments

@bernstei
Copy link
Contributor

bernstei commented Apr 1, 2022

The current approach for the vacancy test, and probably others (other point defects, surfaces?) is to read bulk_supercell.xyz from the test directory, rescale it to match the lattice constant of the corresponding bulk structure (indicated by its bulk_struct_test info field), then relax the atoms without the cell DOFs. This was originally conceived to make it possible for the user to do complicated things like impose a symmetry breaking (like the Si vacancy Jahn-Teller), or add some initial relaxation manually for interstitials.

However, this is incorrect for lower symmetry crystal lattices, because it does not relax the cell shape. For all intents and purposes the test must use a supercell constructed from the relaxed bulk cell (which can be extract from the bulk test). If additional manual adjustments must be made there needs to be some other mechanism to specify them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant