virt-v2v 1.44 incorrectly parses a VMX file with modified disk bus

[bsanders]

Note: This works correctly in 2.2.0 and 2.3.5. I've no expectations a fix will be created for 1.44.x. This issue is primarily for the benefit of others who might stumble across it via Google search, since it exists on the version shipped in Ubuntu LTS repositories. I've not tested it in other distros (but I think RHEL 7 and 8 ships with 1.4X.y).

If you create a VM in VMware with a SCSI disk, then clone it (in VMware), adjusting the guest hardware in the cloning wizard to set it's disk bus to SATA, the resulting VMX file will be written in such a way that virt-v2v (1.44.2!) is unable to find the disks (to be clear, the cloned/modified VM still boots in VMware). The resulting error is:

virt-v2v: error: source has no hard disks!

Attached are the initial VMX file, the VMX file after the clone/hardware adjustment, and the debug output of virt-v2v (all appended with .txt to make github happy).

virt-v2v-output.txt
efi-windows2019-onedisksata-onenic.vmx.txt
efi-windows2019-onediskscsi-onenic.vmx.txt

[k5123]

Running into the same error, but by using nvme disks in the .vmx.

[rwmjones]

Does this fail in a more recent version, ideally 2.6?