Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent duplicate connections when dialing a multiaddr without a peer id #2714

Open
achingbrain opened this issue Sep 23, 2024 · 0 comments · May be fixed by #2734
Open

Prevent duplicate connections when dialing a multiaddr without a peer id #2714

achingbrain opened this issue Sep 23, 2024 · 0 comments · May be fixed by #2734
Labels
exp/beginner Can be confidently tackled by newcomers good first issue Good issue for new contributors kind/enhancement A net-new feature or improvement to an existing feature

Comments

@achingbrain
Copy link
Member

If we dial a multiaddr without a peer id (e.g. /dns/example.com), and we exchange peer IDs with the remote, if we already have a non-circuit relay connection to that peer, the connection manager should close the new connection and return the existing connection.

At the moment we end up with multiple connections to the same peer which wastes resources.
@achingbrain achingbrain added kind/enhancement A net-new feature or improvement to an existing feature good first issue Good issue for new contributors exp/beginner Can be confidently tackled by newcomers labels Sep 23, 2024
@tabcat tabcat linked a pull request Sep 29, 2024 that will close this issue
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
exp/beginner Can be confidently tackled by newcomers good first issue Good issue for new contributors kind/enhancement A net-new feature or improvement to an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: prevent duplicate connections to multiaddr tabcat/js-libp2p
1 participant
@achingbrain