-
Notifications
You must be signed in to change notification settings - Fork 943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metrics dependencies are always pulled via protocol features #2286
Comments
Good catch! Corresponding upstream tracking issue (weak dependency feature): rust-lang/cargo#8832 As far as I can tell there is no solution to this today. I don't it hurts much, given that |
Thanks for pointing me to that, I had no idea that this is being worked on! Very exciting :) |
If I am not mistaken, this can be fixed with Rust |
Closing here, since fixed by @maschad 🎉 |
I am not sure if there is much we can do about it but I noticed that
libp2p-metrics
is automatically pulled in if any of the protocols that activate metrics features are activated.When trying to upgrade to the most recent rust-libp2p HEAD, I saw
libp2p-metrics
come in as a dependency even though we are not specifying it as a feature. I suspect it is being pulled in by cargo due toping
activatinglibp2p-metrics/ping
.rust-libp2p/Cargo.toml
Line 47 in 6d3ab8a
Is there a way of how we can design this differently? Perhaps having a dedicated
metrics
feature within each protocol would solve this?The text was updated successfully, but these errors were encountered: