Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bind from LDIF data source panics when there is no userPassword and the panic is not logged #114

Open
longsleep opened this issue Sep 19, 2023 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@longsleep
Copy link
Collaborator

The panic recover in

if r := recover(); r != nil {
does not get logged.

For example when for whatever reason a user record has no userPassword field, the nesting code in server/handler/ldif/entry.go goes like

ldappassword.Validate(bindSimplePw, entry.UserPassword.Values[0])

and that panics.

Panics should be logged so it is clear why Bind commands return an Operational Error and this particular case should not panic in the first place.

@longsleep longsleep self-assigned this Sep 19, 2023
@longsleep longsleep added the bug Something isn't working label Sep 19, 2023
@longsleep longsleep changed the title Bind from LDFI data source panics when there is no userPassword and the panic is not logged Bind from LDIF data source panics when there is no userPassword and the panic is not logged Sep 19, 2023
@longsleep
Copy link
Collaborator Author

@rhafer i might fix this one soon-ish and then cut a new release - it has been a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant