Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Apple targets have been failing randomly as of late #11517

Closed
sezero opened this issue Nov 21, 2024 · 12 comments
Closed

CI: Apple targets have been failing randomly as of late #11517

sezero opened this issue Nov 21, 2024 · 12 comments

Comments

@sezero
Copy link
Contributor

sezero commented Nov 21, 2024

As title says: See recent commits and/or pull requests.
Re-running the failed ones usually end up in success.

CC: @madebr

@madebr
Copy link
Contributor

madebr commented Nov 21, 2024

I see a few brew install fails.
Perhaps it's worth to wrap it in a for loop and retry a few times.

@maia-s
Copy link
Contributor

maia-s commented Nov 21, 2024

The ones I've seen fail when installing pkgconf

==> Pouring pkgconf--2.3.0_1.arm64_sonoma.bottle.tar.gz
Error: The `brew link` step did not complete successfully
The formula built, but is not symlinked into /opt/homebrew
Could not symlink bin/pkg-config
Target /opt/homebrew/bin/pkg-config
is a symlink belonging to [email protected]. You can unlink it:
  brew unlink [email protected]

To force the link and overwrite all conflicting files:
  brew link --overwrite pkgconf

To list all files that would be deleted:
  brew link --overwrite pkgconf --dry-run

Possible conflicting files are:
/opt/homebrew/bin/pkg-config -> /opt/homebrew/Cellar/[email protected]/0.29.2_3/bin/pkg-config
/opt/homebrew/share/aclocal/pkg.m4 -> /opt/homebrew/Cellar/[email protected]/0.29.2_3/share/aclocal/pkg.m4
/opt/homebrew/share/man/man1/pkg-config.1 -> /opt/homebrew/Cellar/[email protected]/0.29.2_3/share/man/man1/pkg-config.1

@madebr
Copy link
Contributor

madebr commented Nov 22, 2024

Homebrew/brew#18788 might be related

@madebr
Copy link
Contributor

madebr commented Nov 22, 2024

pkg-config is installed by default on the macos runners.
Starting from 0007451, we will no longer install pkg-config (or its newer pkgconf nephew)

@madebr madebr closed this as completed Nov 22, 2024
@slouken
Copy link
Collaborator

slouken commented Nov 22, 2024

Thank you!

@madebr
Copy link
Contributor

madebr commented Nov 22, 2024

There's a part II ;) 848fd1e

@sezero
Copy link
Contributor Author

sezero commented Nov 22, 2024

SDL2 and release-2.30.x branches need similar massage: see failures
for today's commits in those branches

The satellite libs also seem to install pkg-config for Apple targets
and most possibly need similar treatment:
SDL_image, SDL_net: SDL2 branch only
SDL_rtf: main branch only
SDL_mixer, SDL_ttf: main and SDL2 branches

@madebr
Copy link
Contributor

madebr commented Nov 22, 2024

These branches need patches similarly to this one: dface78

@sezero
Copy link
Contributor Author

sezero commented Nov 22, 2024

These branches need patches similarly to this one: dface78

Should I touch the satellite libs like that?

P.S.: release-2.30.x is missing the Windows 32 bit ARM workaround and keep failing at that.

@madebr
Copy link
Contributor

madebr commented Nov 22, 2024

Should I touch the satellite libs like that?

Please do, or keep a mental note and do it when you need to do actual work on the repo?

P.S.: release-2.30.x is missing the Windows 32 bit ARM workaround and keep failing at that.

I tried 01dee78, but am unsure this is a correct fix.

@sezero
Copy link
Contributor Author

sezero commented Nov 22, 2024

Should I touch the satellite libs like that?

Please do, or keep a mental note and do it when you need to do actual work on the repo?

Done

P.S.: release-2.30.x is missing the Windows 32 bit ARM workaround and keep failing at that.

I tried 01dee78, but am unsure this is a correct fix.

Incorrect I guess: still failing.

@madebr
Copy link
Contributor

madebr commented Nov 22, 2024

Incorrect I guess: still failing.

I'm going to backport SDL3's ci build system to SDL2. Looks like I don't know how to set the Windows SDK version for Visual Studio CMake projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants