Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Variadic middleware? #89

Open
xdumaine opened this issue Dec 18, 2023 · 1 comment
Open

Variadic middleware? #89

xdumaine opened this issue Dec 18, 2023 · 1 comment

Comments

@xdumaine
Copy link
Contributor

xdumaine commented Dec 18, 2023 •
edited
Loading

Hey! I saw that there was support for variadic middleware added and subsequently reverted - just wondering what caused that to get reverted per #87, and wondering if there's a workaround. @swain
@swain
Copy link
Contributor

swain commented Jan 10, 2024 •
edited
Loading

@xdumaine Sorry for delayed response here -- holidays, etc.

I'd love too bring back the variadic middleware. The reason it was reverted (as it seems you've discovered) is that it led to unpredictable (and sometimes confusing) type behavior, esp around auto-complete when writing a handler.

I recently had an idea for how it could be re-introduced, with potentially better typing -- I'll get that PR up this week and tag you for awareness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xdumaine @swain