New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unnecessary SPARC g0 override #690

Open

2over12 opened this issue Nov 10, 2023 · 1 comment

Contributor

2over12 commented Nov 10, 2023

I think pcode already handles folding g0 so I dont think these initializations are required:

remill/lib/Arch/Sleigh/SPARC32Base.cpp

Lines 269 to 274 in 17cff6b

    
           ir.CreateStore(zero_u32, ir.CreateAlloca(u32, nullptr, "g0"), false); 
        
           ir.CreateStore(zero_u32, ir.CreateAlloca(u32, nullptr, "ignore_write_to_g0"), 
        
                          false); 
        
           // this is for unknown asr to avoid crash. 
        
           ir.CreateStore(zero_u32, ir.CreateAlloca(u32, nullptr, "asr"), false);

This comment was marked as abuse.

Sign in to view

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment