Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type check lightly.api #1387

Closed
philippmwirth opened this issue Sep 13, 2023 · 1 comment
Closed

Type check lightly.api #1387

philippmwirth opened this issue Sep 13, 2023 · 1 comment
Labels
enhancement

Comments

@philippmwirth
Copy link
Contributor

philippmwirth commented Sep 13, 2023 •
edited by guarin
Loading

Type check lightly.api

  • Work through the excluded files with prefix lightly/api and tests/api in pyproject.toml and type check one by one.
  • Remove follow_imports = skip for lightly.api.*.

Note: Typing the ApiWorkflowClient is a bit tricky because of the mixins. Mypy recommends typing mixins by making them implement a Protocol (see documentation).
@guarin guarin moved this to Todo in Type checking Sep 13, 2023
@SauravMaheshkar
Copy link
Collaborator

Closed in favour of #1635

@github-project-automation github-project-automation bot moved this from Todo to Done in Type checking Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
Type checking
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@guarin @SauravMaheshkar @philippmwirth