Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type check lightly.loss #1391

Closed
philippmwirth opened this issue Sep 13, 2023 · 3 comments
Closed

Type check lightly.loss #1391

philippmwirth opened this issue Sep 13, 2023 · 3 comments
Assignees
@SauravMaheshkar

Comments

@philippmwirth
Copy link
Contributor

philippmwirth commented Sep 13, 2023 •
edited
Loading

Type check lightly.loss

  • Work through the excluded files with prefix lightly/loss and tests/loss in mypy.ini and type check one by one.
  • Remove follow_imports = skip for lightly.loss.*.
@guarin guarin moved this to Todo in Type checking Sep 13, 2023
@SauravMaheshkar
Copy link
Collaborator

Can I take this up ?

@guarin
Copy link
Contributor

guarin commented May 23, 2024

Yes of course, thanks a lot! Will assign the issue to you.

@guarin
Copy link
Contributor

guarin commented Aug 16, 2024

Closed in favor of #1635

@guarin guarin closed this as completed Aug 16, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Type checking Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SauravMaheshkar SauravMaheshkar

Labels
None yet
Projects
Type checking
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@guarin @SauravMaheshkar @philippmwirth