-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose method to send node announcement to specfic peer #2866
Comments
Good morning dear @tnull, I want to contribute to this, please can you provide me with more details while I get the design document ready? |
Can you elaborate a bit on the reason for wanting this? I assume its for the discussion later at #2418, basically for an LSP to be able to manually force an announcement for its clients so that the clients see the LSP's node name? |
Yes, pretty much. Thinking about it once more I'm not entirely sure anymore if a per-peer 'broadcast' would be the right tool, but I think we def. want to find a solution so that (mobile) nodes get as recent data as possible about their immediate counterparties and also possibly their public channels. We're already connected to them, so it's a bit weird to source potentially outdated data from RGS that also wouldn't give us (full) node announcements. I also suspect that we could improve payment reliability if we just learned more quickly about changes in our immediate neighbor's channels, as these are the ones where we don't have any concrete data but route most often across. |
Yea, its kinda awkward to override what a peer told us ("dont share any gossip with me") just because we think they really do want it. When sending our own channel_updates that are fresh I think we probably should (IIRC CLN does this), but that doesn't really help this case too much because the node is probably on mobile and offline when we go to do the update. We may want to have some kind of custom message to say "hey, give me some parts of the graph you think are cool"? |
Hey, I would like to work on this issue, is this up for grabs? |
Ah, I think unfortuantely we're unsure if this is the right way forward. So I'll close this issue for now. Sorry! |
Currently we only expose a general
PeerManager::broadcast_node_announcement
method that allows to broadcast to all connected peers.We should also expose a corresponding method for a specific peer, which would allow us to trigger it after channel opening.
The text was updated successfully, but these errors were encountered: