Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] account: don't change account status until the action has been successfully completed #432

Open
positiveblue opened this issue Jan 12, 2023 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@positiveblue
Copy link
Contributor

When we close an account we first update its status and value in the clientdb and then try to broadcast the spending tx.

If we don't succeed publishing the tx our account will already be marked as pending to close so we won't be able to retry it anymore.

Expected behavior

If attempting to close an account fails, the account is not left in a terminal state. You can continue using it normally or retry to close it

@positiveblue positiveblue added the bug Something isn't working label Jan 12, 2023
@positiveblue positiveblue self-assigned this Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant