Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ask Orders doesn't settle #478

Open
jimmydjabali opened this issue Feb 7, 2024 · 2 comments
Open

Ask Orders doesn't settle #478

jimmydjabali opened this issue Feb 7, 2024 · 2 comments

Comments

@jimmydjabali
Copy link

jimmydjabali commented Feb 7, 2024

Expected behavior
After submitted an "Ask" order (Sell channel), it should automatically open a channel to the selected node.

Actual behavior
After submitted an "Ask" order (Sell channel), the order is blocked on the "ORDER_SUBMITTED" state for several days, with the following details:

{
    "asks":  [
        {
            "details":  {
                "trader_key":  "XXXXX",
                "rate_fixed":  694,
                "amt":  "10000000",
                "max_batch_fee_rate_sat_per_kw":  "12500",
                "order_nonce":  "XXXXX",
                "state":  "ORDER_SUBMITTED",
                "units":  100,
                "units_unfulfilled":  100,
                "reserved_value_sat":  "10002135",
                "creation_timestamp_ns":  "1707304700838378803",
                "events":  [
                    {
                        "timestamp_ns":  "1707304700838378803",
                        "event_str":  "OrderCreated"
                    }
                ],
                "min_units_match":  100,
                "channel_type":  "ORDER_CHANNEL_TYPE_PEER_DEPENDENT",
                "allowed_node_ids":  [
                    "XXXXX"
                ],
                "not_allowed_node_ids":  [],
                "auction_type":  "AUCTION_TYPE_BTC_INBOUND_LIQUIDITY",
                "is_public":  true
            },
            "lease_duration_blocks":  2016,
            "version":  5,
            "announcement_constraints":  "ANNOUNCEMENT_NO_PREFERENCE",
            "confirmation_constraints":  "CONFIRMATION_NO_PREFERENCE"
        }
    ],
    "bids":  []
}

To reproduce

System information

I'm using Pool as part of Lightning Terminal.

@Roasbeef
Copy link
Member

Roasbeef commented Feb 7, 2024

If you do pool getinfo what's your node's tier in node_rating? That needs to be TIER_1 to allow you to submit asks in the "main" market.

After submitted an "Ask" order (Sell channel), it should automatically open a channel to the selected node.

Note that this is a market, you won't automatically have you asked order be filled. Filling an ask order means someone had a corresponding bid order (wanted to buy a channel at the rate you posted).

@jimmydjabali
Copy link
Author

jimmydjabali commented Feb 8, 2024

@Roasbeef The node is TIER_1.

I didn't posted, but directly matched an offer in the "Sell" tab. So I expect the remote's node is willing/ready to accept new channels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants