Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature]: Expand the notification scope of SubscribeRfqEventNtfns #1268

Open
lukegao209 opened this issue Dec 27, 2024 · 0 comments
Open

[feature]: Expand the notification scope of SubscribeRfqEventNtfns #1268

lukegao209 opened this issue Dec 27, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@lukegao209
Copy link
Contributor

Conditions:

1.	A Taproot Asset Channel exists between Alice and Bob.
2.	Alice adds a Taproot Assets Invoice using the AddInvoice method.
3.	Alice receives a PeerAcceptedBuyQuote event notification, but Bob does not receive any notification.

Requirement:

  1. Add Notification for Bob:
    Enhance the notification system so that Bob also receives a notification when Alice creates a Taproot Assets Invoice. This will allow Bob’s tapd to accurately identify key invoice details, such as asset_amount and AssetRate. Providing Bob with this information will help tapd process its own business logic more effectively.

  2. Include baseScid Field:
    Add a baseScid field to the notification data. This field will facilitate the identification of the specific channel and associated assetId, improving clarity and processing accuracy for both Alice and Bob’s tapd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 🆕 New
Development

No branches or pull requests

1 participant