Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support OpenTelemetry configuration options #127

Open
jenni opened this issue Jun 21, 2022 · 7 comments
Open

Support OpenTelemetry configuration options #127

jenni opened this issue Jun 21, 2022 · 7 comments

Comments

@jenni
Copy link

jenni commented Jun 21, 2022

Is your feature request related to a problem? Please describe.
OpenTelemetry has a list of supported configurations that the LS Launcher is missing. Example:
DB statement sanitization: https://opentelemetry.io/docs/instrumentation/java/automatic/agent-config/#db-statement-sanitization

Describe the solution you'd like
Support all available config options for the OpenTelemetry agent.

@gregdeane
Copy link

+1

@carlosalberto
Copy link
Contributor

Hey hey - all these configuration should work just fine. The Java Launcher simply pre-configures some parameters (e.g. OTLP ingestion path, OTLP headers), but anything else works fine and transparently. Are you having a specific problem or a use case is not working as expected?

@jenni
Copy link
Author

jenni commented Jun 28, 2022

@carlosalberto I can't log the db attributes in Lightstep.

  1. added the OTEL_INSTRUMENTATION_COMMON_DB_STATEMENT_SANITIZER_ENABLED=false env var., I could still see ?.
  2. tried adding -Dotel.instrumentation.common.db-statement-sanitizer.enabled=false, did not work, same ?.
  3. tried adding otel.instrumentation.common.db-statement-sanitizer.enabled in the application.properties file, did not work, same ?.

I took a quick look to the project. [I might be missing something essential but...] it seems that some Opentelemetry configs are not read by the VariablesConverter class, so the agent is always configured with the default values, in this particular example: OTEL_INSTRUMENTATION_COMMON_DB_STATEMENT_SANITIZER_ENABLED=true

@carlosalberto
Copy link
Contributor

Interesting. Variables converter pre-sets some values, but properties should flow transparently. Will take a second look to double check what's going on.

@jenni
Copy link
Author

jenni commented Jul 7, 2022

@carlosalberto any news on this?:)

@codeboten
Copy link
Contributor

Hi @jenni! Apologies for the delay here, @carlosalberto is coming back from PTO next week and will follow up here.

@jenni
Copy link
Author

jenni commented Aug 19, 2022

@codeboten @carlosalberto it's a pity that it's been 2 months since I opened this issue and haven't heard back from anyone. I have tried to look into it myself but I can't start the project as some environment variables are missing and there's no documentation on how to contribute here. I guess the best would be to add some docs or simply deprecate the repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants