Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remerge from aguillon/permit-cameligo #10

Open
aguillon opened this issue Jan 17, 2024 · 0 comments
Open

Remerge from aguillon/permit-cameligo #10

aguillon opened this issue Jan 17, 2024 · 0 comments

Comments

@aguillon
Copy link

https://github.com/aguillon/permit-cameligo/ has diverged from the official repository (sorry, I wasn't tracking it) but is more modern. Among other things, it uses the recently merged version of @ligo/fa instead of extendable-fa2, changes the admin to a set and adds an entrypoint to remove an admin, and rewrites the tests to use breathalyzer instead of a custom test suite.

Can we list here what I need to do to merge my changes into yours? I think we can reset to d6e61b0 (last common ancestor), as most changes that happened after this commit seem to be about migration to Ligo v1.

Then I need to

  • drop submodules and use registry instead (breathalyzer and ligo/fa both should be available in registry), and
  • make sure TZIP 17 is correctly implemented and write tests about it.

Anything else?

It is likely that this code becomes mostly obsolete after the next version of Tezos. However, permits can still be used for other things, so I will probably start a new library from this repository in the future. @Laucans, is it possible to change the name and category of a project on Registry after it has been added? From "permit-cameligo" to "permit-library", for instance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant