-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translations (and public ressources) #12
Comments
hmm i would suggest to simply make the translation key dynamic |
no way until this symfony/symfony#971 will be resolved |
i must admit i am a backend guy, so i don't know the entire translation stuff all that well. |
hiho! |
i currently do not have the intention to work on this .. i recognize that for theming other aspects might also be necessary .. so if someone cooks up a proposal i am willing to evaluate it. |
I am propose change current directory structure to something like this
this is BC-break, because now templates located directly at I can work on this issue if you approove this proposal. |
So what do you think about my proposal? |
i am open to this change .. since added some flexibility in the order of directories, we might even be able to keep BC. btw there is also https://github.com/Sylius/SyliusThemingBundle from which we might be able to draw some inspiration. IIRC the bundle was once even based on this bundle. |
+1 for including (public) assets as well. A theme is more than just views, it would be great if any resource can live inside a theme. |
What about Translations ? If i use another theme, i want to load another translation-file too! it is possible to regard this too ? or maybe some workarounds ?
greez,
sky...
The text was updated successfully, but these errors were encountered: