Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing parent/child themes #127

Open
ahilles107 opened this issue Jun 2, 2015 · 4 comments
Open

Introducing parent/child themes #127

ahilles107 opened this issue Jun 2, 2015 · 4 comments

Comments

@ahilles107
Copy link
Contributor

What do you think about idea of declaring parent theme for theme and parameter parent_theme in path_patterns ? This would allow for us implement themes updating and keeping customer/user theme changes not removed.

Something like:

themes: 
  theme_1: ~
  theme_2: ~
  theme_3: 
    parent: theme_1
@ahilles107
Copy link
Contributor Author

@lsmith77 - what do You think?

@lsmith77
Copy link
Contributor

lsmith77 commented Jun 4, 2015

should't twig inheritance be sufficient?

@wizhippo
Copy link
Contributor

wizhippo commented Jun 4, 2015

I think using theme cascading order could be used here. It would be nice if there was a way to change the patterns based on the current theme selected so you could add base themes to the cascade order based on the active theme..

Perhaps the FileLocator could be changed to allow changing the patterns and then some listener to update the cascade order based on the current theme?

@oleg-andreyev
Copy link
Contributor

@wizhippo I my company we've have quite complicated template inheritance, and we've achieved that using path_patterns will all paths.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants