Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should guard SL feed empty URL #190

Open
edmondyu opened this issue Aug 8, 2020 · 3 comments
Open

Should guard SL feed empty URL #190

edmondyu opened this issue Aug 8, 2020 · 3 comments
Labels
bug 🐛 Something isn't working

Comments

@edmondyu
Copy link
Contributor

edmondyu commented Aug 8, 2020

0.19.0 (build 214)
iPhone SE iOS 13.5.1
Liker ID: edmondyu

Can be repeated even killing the app and restart.

The issue happens in previous build as well.

crash2

@edmondyu
Copy link
Contributor Author

edmondyu commented Aug 8, 2020

入 Brave browser 登入 Liker Land 後,行 https://liker.land/api/reader/superlike/followed 出以下 result:

{
  "list": [
    {
      "superLikeID": "1411226014995848",
      "referrer": "https://bchai.cc/2020/08/07/drink-a-toast/",
      "ts": 1596849268242,
      "user": "edmondyu",
      "liker": "brenday"
    },
    {
      "superLikeID": "1410317231835580",
      "referrer": "https://www.sun-line.idv.tw/blog/?p=3307",
      "ts": 1596821938341,
      "user": "sunline58311",
      "liker": "sunline58311"
    },
    {
      "superLikeID": "1410131879489283",
      "referrer": "https://medium.com/heidiluocreative/11%E5%80%8B%E6%89%93%E9%80%A0%E5%AE%8C%E7%BE%8E%E7%9D%A1%E7%9C%A0%E7%92%B0%E5%A2%83%E7%9A%84%E7%A2%BA%E8%AA%8D%E6%B8%85%E5%96%AE-452c170a449d",
      "ts": 1596816339470,
      "user": "heidiluo",
      "liker": "ngwingtat"
    },
    {
      "superLikeID": "1409956168983170",
      "referrer": "https://madman-magazine.com/blog/coca-cola/",
      "ts": 1596810358803,
      "user": "madmanmonologue",
      "liker": "madmanmonologue"
    },
    {
      "superLikeID": "1409898637816074",
      "referrer": "https://vocus.cc/@sunline/5f2d10f2fd89780001c2f9d0",
      "ts": 1596808104990,
      "user": "sunline58311",
      "liker": "sunline58311"
    },
    {
      "superLikeID": "1409802782475956",
      "referrer": "https://thestandnews.com/art/%E5%81%9A%E5%9C%B0%E7%9B%A430%E5%B9%B4-%E4%BB%96%E5%89%9B%E8%AE%80%E5%AE%8C%E8%97%9D%E8%A1%93%E5%AD%B8%E5%A3%AB-%E5%B0%88%E8%A8%AA70%E6%AD%B2%E4%BD%95%E5%A5%87%E7%87%84/",
      "ts": 1596803431479,
      "user": "standnews",
      "liker": "ettachan"
    },
    {
      "superLikeID": "1409774679053956",
      "referrer": "https://clipversity.com/article/-MDsu4AQIRSpe5CZ_4G0",
      "ts": 1596801767954,
      "user": "oneming",
      "liker": "clipversity"
    },
    {
      "superLikeID": "1409591670028576",
      "referrer": "",
      "ts": 1596791306332,
      "user": "familyonlinetv",
      "liker": "drthankyouc"
    },
    {
      "superLikeID": "1409589458416865",
      "referrer": "https://medium.com/@veryotaku/%E5%A6%82%E4%BD%95%E7%94%A8likecoin%E8%B2%B7civic-liker%E6%9C%83%E7%B1%8D-b2cc143650b4",
      "ts": 1596790766409,
      "user": "veryotaku",
      "liker": "withthepoons"
    },
    {
      "superLikeID": "1409523361367737",
      "referrer": "https://thestandnews.com/nature/%E5%8B%87%E9%97%96%E9%9D%92%E8%9B%99%E7%9B%B4%E8%85%B8%E5%B9%B3%E5%AE%89%E7%84%A1%E4%BA%8B%E7%9A%84%E7%94%B2%E8%9F%B2/",
      "ts": 1596787158659,
      "user": "siufeiball",
      "liker": "edmondyu"
    },
    {
      "superLikeID": "1409462579504288",
      "referrer": "https://www.youput.org/Articles/Details/37bd86d8-f770-4f30-935a-7774dd45a34d",
      "ts": 1596784507396,
      "user": "a0936777705",
      "liker": "a0936777705"
    },
    {
      "superLikeID": "1409419519175158",
      "referrer": "https://thestandnews.com/politics/%E6%B8%AF%E7%89%88%E5%9C%8B%E5%AE%89%E6%B3%95%E5%AF%A6%E6%96%BD%E7%B4%B0%E5%89%87%E5%88%8A%E6%86%B2-%E4%BF%9D%E5%AE%89%E5%B1%80%E5%8F%AF%E7%94%B3%E8%AB%8B%E5%87%8D%E7%B5%90%E6%B6%89%E6%A1%88%E8%B2%A1%E7%94%A2-%E7%B7%8A%E6%80%A5%E6%83%85%E6%B3%81%E8%AD%A6%E6%96%B9%E8%87%AA%E6%89%B9%E5%85%A5%E5%B1%8B%E6%90%9C%E8%AD%89/",
      "ts": 1596782001721,
      "user": "standnews",
      "liker": "ckxpress"
    },
    {
      "superLikeID": "1409388471676207",
      "referrer": "https://medium.com/@veryotaku/%E5%A6%82%E4%BD%95%E7%94%A8likecoin%E8%B2%B7civic-liker%E6%9C%83%E7%B1%8D-b2cc143650b4",
      "ts": 1596780272997,
      "user": "veryotaku",
      "liker": "veryotaku"
    },
    {
      "superLikeID": "1409351586585302",
      "referrer": "https://thestandnews.com/society/%E8%A8%98%E4%B8%80%E5%80%8B%E7%B4%B0%E5%BA%AD%E7%9A%84%E8%A5%B2%E8%AD%A6%E6%A1%88-%E8%BE%AF%E6%96%B9%E5%A4%A7%E7%8B%80%E5%90%91%E4%BB%96%E7%9A%84client%E8%AA%AA-%E5%A0%82%E5%A0%82%E6%AD%A3%E6%AD%A3%E8%A1%8C%E5%87%BA%E5%8E%BB/",
      "ts": 1596778924282,
      "user": "chengmeichi2016",
      "liker": "wrightfu"
    },
    {
      "superLikeID": "1408946032592519",
      "referrer": "https://madman-magazine.com/blog/doraemon/",
      "ts": 1596764829583,
      "user": "madmanmonologue",
      "liker": "madmanmonologue"
    },
    {
      "superLikeID": "1407968919225303",
      "referrer": "https://vocus.cc/@sunline/5f2b7447fd89780001b02a5a",
      "ts": 1596735109792,
      "user": "sunline58311",
      "liker": "sunline58311"
    },
    {
      "superLikeID": "1407667433506251",
      "referrer": "https://techmoon.xyz/how-to-crack-download-limit-of-baidu-netdisk/",
      "ts": 1596727299065,
      "user": "slivenred",
      "liker": "chiyi4488"
    },
    {
      "superLikeID": "1407644562008368",
      "referrer": "https://nowtostart.com/epic/",
      "ts": 1596726646540,
      "user": "liliumhuang",
      "liker": "edmondyu"
    },
    {
      "superLikeID": "1407632744630435",
      "referrer": "https://www.youput.org/Articles/Details/a16df58a-3113-4c0f-bd18-a4f5ff1062b9",
      "ts": 1596726496552,
      "user": "a0936777705",
      "liker": "a0936777705"
    },
    {
      "superLikeID": "1407559425265069",
      "referrer": "https://vocus.cc/@yochen/5e8a0671fd89780001c22baf",
      "ts": 1596724306404,
      "user": "yochen8361",
      "liker": "wrightfu"
    }
  ]
}

@nwingt
Copy link
Member

nwingt commented Aug 8, 2020

Seems one of the SL from the feed is causing error

{
  "superLikeID": "1409591670028576",
  "referrer": "",
  "ts": 1596791306332,
  "user": "familyonlinetv",
  "liker": "drthankyouc"
}

@nwingt nwingt added the bug 🐛 Something isn't working label Aug 8, 2020
@nwingt
Copy link
Member

nwingt commented Aug 8, 2020

Applied patch to the API
Need to guard this issue

@nwingt nwingt changed the title Hang on a green screen during loading the list view Should guard SL feed empty URL Aug 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants