Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experiment virtual threads with reactor #1082

Open
vttranlina opened this issue Jun 4, 2024 · 10 comments
Open

Experiment virtual threads with reactor #1082

vttranlina opened this issue Jun 4, 2024 · 10 comments
Assignees

Comments

@vttranlina
Copy link
Member

The current source code is Java 21 and it supports virtual threads,
We can experiment with it with reactor by setting the JVM argument
-Dreactor.schedulers.defaultBoundedElasticOnVirtualThreads=true

Try it on staging, run Gatling performance test, and compare before/after

ref: https://spring.io/blog/2023/10/31/what-new-is-coming-in-reactor-core-3-6-0

@chibenwa
Copy link
Member

chibenwa commented Jun 4, 2024

Cool!

Please read completly virtual thread limitations regarding thread pinning and do an overall report here too.

@hungphan227 hungphan227 self-assigned this Jul 10, 2024
@hungphan227
Copy link
Contributor

hungphan227 commented Jul 11, 2024

perf test imap 10k - no virtual thread

Image

@hungphan227
Copy link
Contributor

perf test imap 10k - virtual thread enabled

Image

@hungphan227
Copy link
Contributor

perf test result with virtual thread seems to be better but not much (99th: 919 vs 1194). I am not sure that the performance change is due to virtual thread or environment unstability.

@chibenwa
Copy link
Member

We likely can PR use of virtual threads in bounded elastic

@Arsnael
Copy link
Member

Arsnael commented Jul 18, 2024

Status on this?

@hungphan227
Copy link
Contributor

Due to the other ticket I am currently doing, the sandbox environment is not available to conduct test. Will be back to this one after sandbox is recovered.

@Arsnael
Copy link
Member

Arsnael commented Jul 22, 2024

Not urgent though

@chibenwa
Copy link
Member

Status please?

If nothing happens on that then let's move it to backlog.

@chibenwa
Copy link
Member

chibenwa commented Nov 8, 2024

I opened back this ticket by accident: still very relevant ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants