Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Generated password is not copied to clipboard on click #609

Open
Te-Z opened this issue Jul 22, 2024 · 3 comments
Open

[Bug] Generated password is not copied to clipboard on click #609

Te-Z opened this issue Jul 22, 2024 · 3 comments
Labels

Comments

@Te-Z
Copy link

Te-Z commented Jul 22, 2024

Describe the bug
A clear and concise description of what the bug is.

After creating a password, when I click the box with the password it is not copied to clipboard

Tested on Chrome https://drive.stg.lin-saas.com/

To Reproduce
Steps to reproduce the behavior:

  1. I click “…” next to a folder or a file on my drive
  2. I select Share
  3. I select access rights (read, write)
  4. Once I set access rights to anything other than “No access”, advanced settings for the link and the “Copy” button are displayed
  5. I check the box “Password”
  6. An auto-generated password is displayed there
  7. I can change the password
  8. When I click the box with the password, is not copied to clipboard

Expected behavior
A clear and concise description of what you expected to happen.

When I click the box with the password, it is copied to clipboard. I see a toast message

Screenshots
If applicable, add screenshots to help explain your problem.

Capture.video.du.22-07-2024.12.47.20.webm
@Te-Z Te-Z added the bug Something isn't working label Jul 22, 2024
@ericlinagora ericlinagora added feature and removed bug Something isn't working labels Jul 22, 2024
@ericlinagora
Copy link
Contributor

I don't think we should be overwriting the user's clipboard, if the user wants to copy the password, the user can do it in the normal ways stuff is copied. People keep valuable information in their clipboard, replacing it without their request is risky.

@Popokok
Copy link

Popokok commented Oct 2, 2024

How about adding a button to give user an option to copy to clipboard?

@ericlinagora
Copy link
Contributor

Sounds good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants