Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Story] Make consistent "next page token" field for all DB types #647

Closed
shepilov opened this issue Sep 18, 2024 · 0 comments · Fixed by #648
Closed

[Story] Make consistent "next page token" field for all DB types #647

shepilov opened this issue Sep 18, 2024 · 0 comments · Fixed by #648
Assignees
@MontaGhanmy
Labels
tech techdebt
Milestone
v1.0.5

Comments

@shepilov
Copy link
Member

In the document service remove code
dbType === "mongodb" ? parseInt(page_token) : parseInt(page_token) / parseInt(limitStr);

The next page token should be always in the same field for all dataTypes
@MontaGhanmy MontaGhanmy self-assigned this Sep 18, 2024
@MontaGhanmy MontaGhanmy linked a pull request Sep 18, 2024 that will close this issue
✨ Added offset pagination to db connector #648
Merged
@ericlinagora ericlinagora added this to the v1.0.5 milestone Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MontaGhanmy MontaGhanmy

Labels
tech techdebt
Projects
None yet
Milestone
v1.0.5
Development

Successfully merging a pull request may close this issue.

✨ Added offset pagination to db connector linagora/twake-drive
3 participants
@MontaGhanmy @shepilov @ericlinagora