Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About the compress feature (with internal dictionaries) #444

Open
Jimmy-Z opened this issue Jan 6, 2025 · 2 comments
Open

About the compress feature (with internal dictionaries) #444

Jimmy-Z opened this issue Jan 6, 2025 · 2 comments

Comments

@Jimmy-Z
Copy link
Contributor

Jimmy-Z commented Jan 6, 2025

The current implementation does reduce the binary size but at the cost of increasing runtime memory usage, since the static compressed data can't be freed, thus still kept in memory (until OS decides to page it out).

I think it's not really a worthwell trade-off, if users do want smaller binaries, just use UPX, it decompresses in-place.

@mosuka
Copy link
Member

mosuka commented Jan 7, 2025

@Jimmy-Z
I see. That is very interesting.
I am not familiar with UPX, but is it possible to achieve this without external dependencies?
For example, do we need to install something with apt commands?

@Jimmy-Z
Copy link
Contributor Author

Jimmy-Z commented Jan 8, 2025

AFAIK, yes, we need to install upx in the build script if we want to release compressed binaries, but I think a section in readme/FAQ like "if you want smaller binaries, you could use upx“ should be enough?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants