This repository has been archived by the owner on Jul 15, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 32
Support composition on Wayland (and x11) #119
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 tasks
waywardmonkeys
previously requested changes
Jul 25, 2023
I've moved this to a draft, because I need to reconsider our interactions with the input lock |
How the progress? |
Needs testing and review, but if everything else is OK, we're ready to land. Still need to fixup clippy and change the default features back to just x11, but otherwise it should work! |
DJMcNab
dismissed
waywardmonkeys’s stale review
August 5, 2023 10:46
The requested inlining is complete
Not sure how these happened
jneem
approved these changes
Aug 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's been a little while since I've tested this personally, but I'm happy to provide the rubber stamp.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards #118.
This is nearly complete - I need to make sure it interacts correctly with the normal IME and manual updates to the text field (e.g. mouse selections, etc.)
I've made a few potentially controversial decisions primarily around cancellation. See the big block of text in
src/text.rs
for some context.To play around with this on GNOME, either use:
or apply
It should just work on KDE, as KDE doesn't use IME for compose.