Skip to content
This repository has been archived by the owner on Jul 15, 2024. It is now read-only.

Update to AccessKit 0.12 #173

Merged
merged 2 commits into from
Nov 23, 2023
Merged

Update to AccessKit 0.12 #173

merged 2 commits into from
Nov 23, 2023

Conversation

mwcampbell
Copy link
Collaborator

The biggest change in glazier itself is that glazier, rather than the application, is now responsible for telling AccessKit about the focus state of the window, because this is now tracked in the AccessKit platform adapter rather than in the tree itself. Most of the other breaking API changes affected the example.

Copy link
Member

@DJMcNab DJMcNab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies, didn't realise that this PR had been opened.

These changes look good, thanks. The one surprise is that the focused bool in the accesskit adapters is per-window. Will there be any change needed there to allow multi-window applications, or does each window naturally get its own adapter (i.e. there's no risk of them overwriting each other)

I think you should have permission to merge this yourself, but if not let me know

@mwcampbell
Copy link
Collaborator Author

Each window gets its own adapter. We even decided to make the API work that way for our AT-SPI backend, at the cost of some implementation complexity, both for consistency with other platforms and because our ideal future GNOME accessibility stack will not have a top-level application object as AT-SPI does.

@mwcampbell mwcampbell added this pull request to the merge queue Nov 23, 2023
Merged via the queue into main with commit b79dd1b Nov 23, 2023
7 checks passed
@DJMcNab DJMcNab deleted the accesskit-0.12 branch November 23, 2023 13:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants