This repository has been archived by the owner on Jul 15, 2024. It is now read-only.
Clean up druid-shell info and add new info to Cargo.toml.
#125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DJMcNab
reviewed
Jul 30, 2023
There was a problem hiding this comment.
I want to check that we actually use the image crate at all. I had been intending to just remove the giant stack of random features.
Alternatively, could we use image = * or equivalent to just use whatever version of the image crate is in the binary, and then not re-export?
|
Worth checking indeed. I think in Druid |
|
I confirmed that |
waywardmonkeys
approved these changes
Jul 30, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cargo.tomlstill contained a bunch ofdruid-shellinfo that hadn't been changed since forking. This PR addresses that.I also added better example scraping for docs, which is ported over from the latest
druid-shell.