Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PreferenceBase with Softcapping? #426

Open
cinjon opened this issue Dec 4, 2024 · 2 comments · May be fixed by #437
Open

PreferenceBase with Softcapping? #426

cinjon opened this issue Dec 4, 2024 · 2 comments · May be fixed by #437

Comments

@cinjon
Copy link

cinjon commented Dec 4, 2024

🚀 The feature, motivation and pitch

There's softcapping in the FusedLinearCrossEntropy; it would be nice to have this natively for PreferenceBase too.

Alternatives

No response

Additional context

No response
@ByronHsu
Copy link
Collaborator

ByronHsu commented Dec 4, 2024

Are you willing to contribute? The change should be starter friendly

@ryankert01
Copy link
Contributor

#take I would like to try to help on this one!

@ryankert01 ryankert01 linked a pull request Dec 8, 2024 that will close this issue
Draft
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[WIP] Add softcapping to preference based fused linear ryankert01/Liger-Kernel
3 participants
@cinjon @ByronHsu @ryankert01