Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The number of bits should be (numbers size in bits - 1), but not exactly (64 - 1) bit. #11

Open
Konard opened this issue Jan 24, 2022 · 0 comments
Open

The number of bits should be (numbers size in bits - 1), but not exactly (64 - 1) bit. #11

Konard opened this issue Jan 24, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@Konard
Copy link
Member

Konard commented Jan 24, 2022 •
edited
Loading

Data.Doublets.Sequences/csharp/Platform.Data.Doublets.Sequences/Numbers/Raw/BigIntegerToRawNumberSequenceConverter.cs

Lines 96 to 98 in 5d08a79

var rawNumber = AddressToNumberConverter.Convert(bigIntWithBitMask);
rawNumbers.Add(rawNumber);
currentBigInt >>= 63;

This will not work for uint, ushort, byte.
@Konard Konard added the bug Something isn't working label Jan 24, 2022
@Konard Konard changed the title The number of bits should be numbers size in bits - 1, but not exactly 64 - 1 bit. The number of bits should be (numbers size in bits - 1), but not exactly (64 - 1) bit. Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Konard