Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NewSignatureData casts crypto.Signer to specific implementations. #421

Open
werwurm opened this issue Sep 6, 2024 · 0 comments
Open

NewSignatureData casts crypto.Signer to specific implementations. #421

werwurm opened this issue Sep 6, 2024 · 0 comments

Comments

@werwurm
Copy link
Contributor

werwurm commented Sep 6, 2024

NewSignatureData casts crypto.Signer interface unnecessarily into specific golang crypto implementations. This prevents the use of other implementations, e.g., for signing with an HSM backed key.

I propose this [1] change to allow for generic crypto.Signer use.

[1] #420
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@werwurm