Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support balance_performance #1458

Merged
merged 1 commit into from
Nov 1, 2023
Merged

feat: support balance_performance #1458

merged 1 commit into from
Nov 1, 2023

Conversation

Decodetalkers
Copy link
Contributor

Log:

@Decodetalkers Decodetalkers force-pushed the supportbalance_performance branch from 629b2ae to 86273ed Compare October 24, 2023 07:41
@Decodetalkers
Copy link
Contributor Author

/check obs

@deepin-bot
Copy link

deepin-bot bot commented Oct 24, 2023

Deepin ChatOps Bot
Deepin redeliveried failed, need update or recreate pull request!!!

@Decodetalkers Decodetalkers force-pushed the supportbalance_performance branch 4 times, most recently from 880b8bd to 9358965 Compare October 26, 2023 05:34
@Decodetalkers
Copy link
Contributor Author

/integrate battery_balance_performance

@github-actions
Copy link

AutoIntegrationPr Bot
auto integrate with pr url: deepin-community/Repository-Integration#616
PrNumber: 616
PrBranch: topic-auto-integration-battery_balance_performance

@deepin-community-ci-bot deepin-community-ci-bot bot mentioned this pull request Oct 26, 2023
Open
@Decodetalkers
Copy link
Contributor Author

/integrate battery_balance_performance

@Decodetalkers Decodetalkers force-pushed the supportbalance_performance branch from 17e66e2 to 0adfbcf Compare October 26, 2023 06:01
@Decodetalkers
Copy link
Contributor Author

/integrate battery_balance_performance

@Decodetalkers
Copy link
Contributor Author

/check obs

@Decodetalkers Decodetalkers force-pushed the supportbalance_performance branch from 0adfbcf to 1947453 Compare October 26, 2023 06:15
@Decodetalkers
Copy link
Contributor Author

/integrate battery_balance_performance

@Decodetalkers Decodetalkers force-pushed the supportbalance_performance branch from 5468510 to 30d4f31 Compare October 26, 2023 07:25
@Decodetalkers
Copy link
Contributor Author

/integrate battery_balance_performance

@Decodetalkers Decodetalkers force-pushed the supportbalance_performance branch from ac11e2f to 8431211 Compare October 26, 2023 09:13
@Decodetalkers
Copy link
Contributor Author

/integrate battery_balance_performance

@Decodetalkers Decodetalkers force-pushed the supportbalance_performance branch 3 times, most recently from f952b5a to 87e2553 Compare October 31, 2023 08:25
@Decodetalkers
Copy link
Contributor Author

/check obs

4 similar comments
@Decodetalkers
Copy link
Contributor Author

/check obs

@Decodetalkers
Copy link
Contributor Author

/check obs

@Decodetalkers
Copy link
Contributor Author

/check obs

@Decodetalkers
Copy link
Contributor Author

/check obs

@Decodetalkers Decodetalkers requested review from BLumia and a team November 1, 2023 05:11
@Decodetalkers Decodetalkers force-pushed the supportbalance_performance branch from 87e2553 to 566e9d1 Compare November 1, 2023 06:29
@Decodetalkers
Copy link
Contributor Author

/check obs

@deepin-bot
Copy link

deepin-bot bot commented Nov 1, 2023 •
edited
Loading

Deepin Obs Bot
Deepin redeliveried failed, need update or recreate pull request!!!

@Decodetalkers Decodetalkers requested review from a team and 18202781743 November 1, 2023 07:54
18202781743
18202781743 reviewed Nov 1, 2023
View reviewed changes
src/plugin-power/window/generalmodule.cpp Outdated
QStandardItem *items = m_powerPlanModel->item(i, 0);
if (items->data(PowerPlanRole).toString() == PERFORMANCE) {
m_powerPlanModel->removeRow(i+1);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

使用removeRows，不然得按照先删除i+1,再删除i, 容易出错，

src/plugin-power/window/generalmodule.cpp
@@ -128,12 +152,56 @@ void GeneralModule::initUI()
DStandardItem *powerPlanItem =
new DStandardItem(m_powerPlanMap.value(PERFORMANCE));
powerPlanItem->setData(PERFORMANCE, PowerPlanRole);
m_powerPlanModel->insertRow(1, powerPlanItem);
if (row_count == 6) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

考虑用 insertRows，放置下标错乱问题，

@Decodetalkers Decodetalkers force-pushed the supportbalance_performance branch from 566e9d1 to 5265c1e Compare November 1, 2023 08:19
@Decodetalkers Decodetalkers force-pushed the supportbalance_performance branch from 5265c1e to ac5ee46 Compare November 1, 2023 08:20
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, Decodetalkers

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

2 similar comments
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, Decodetalkers

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, Decodetalkers

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Decodetalkers
Copy link
Contributor Author

/merge

@deepin-bot deepin-bot bot merged commit 2f6e723 into linuxdeepin:master Nov 1, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@18202781743 18202781743 18202781743 approved these changes

@BLumia BLumia Awaiting requested review from BLumia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Decodetalkers @deepin-ci-robot @18202781743