Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: item is hidden partially in settingsdialog #344

Merged
merged 1 commit into from
May 21, 2024

Conversation

FeiWang1119
Copy link
Contributor

need to hide the wrap widget which contains item widgets

Issue: linuxdeepin/developer-center#8664

need to hide the wrap widget which contains item widgets

Issue: linuxdeepin/developer-center#8664
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • Service::showHideOpacityAndBlurOptions函数中,使用了strcmp进行字符串比较,建议使用QString的比较方法以提高代码的可读性和一致性。
  • wrapWidget的命名可能不够直观,建议使用更具描述性的变量名,以便于理解其作用。

是否建议立即修改:

@FeiWang1119 FeiWang1119 requested review from BLumia and ArchieMeng May 21, 2024 06:57
Copy link
Contributor

@ArchieMeng ArchieMeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ArchieMeng, FeiWang1119

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ArchieMeng ArchieMeng merged commit 90905b0 into linuxdeepin:master May 21, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants