feat: remove the limit of term splitting #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA. |
|
/check clacheck/CLAssistant |
|
Deepin Obs Bot |
|
deepin-terminal/src/views/termwidget.cpp Line 126 in 7a69abb 这里有设置最小的大小限制，小窗口下显示分屏多的话，下面的分屏终端显示会被遮盖。 |
|
recheck |
|
I have read the CLA Document and I hereby sign the CLA. |
hualet
force-pushed
the
remove_split_count_limit
branch
from
23bf46b to
5516f54
Compare
|
a feature request from here: https://bbs.deepin.org/post/277237
fix no term gets focus after closing one, which will cause crashes if you hit Alt+Q in sequence.
original minimum size relies on the limit of one can only split the terminal once, since we removed the limits, the minimum size should change accordingly
fix the bug that new term not showing right after the old one after the splitting
hualet
force-pushed
the
remove_split_count_limit
branch
from
5516f54 to
6d03e2c
Compare
fix the bug that new term has wrong size after splitting
hualet
force-pushed
the
remove_split_count_limit
branch
from
6d03e2c to
eee66bc
Compare
|
@rb-union @ArchieMeng done! |
ArchieMeng
requested changes
Sep 1, 2024
There was a problem hiding this comment.
Basically LGTM.
Additionally, a commit message is required by https://github.com/linuxdeepin/deepin-terminal/actions/runs/10635689078/job/29485856049?pr=353
disable splitting menu when there's no enough room for splitting
fix shortcut still work even when there's no room for splitting
createSubSplit has side effects, it removes the term form its parent, so find size of it in QSplitter::sizes crashes.
hualet
force-pushed
the
remove_split_count_limit
branch
from
12de9a0 to
f7d6de1
Compare
deepin pr auto review关键摘要:
是否建议立即修改: |
ArchieMeng
requested changes
Sep 4, 2024
src/main/mainwindow.cpp
Outdated
| @@ -1131,7 +1131,7 @@ inline void MainWindow::slotShortcutHorizonzalSplit() | |||
| // 判读数量是否允许分屏 | |||
| if (Service::instance()->isCountEnable()) { | |||
| TermWidgetPage *page = currentPage(); | |||
| if (page && CanSplit(page->currentTerminal(), Qt::Vertical)) { | |||
| if (page && TermWidget::canSplit(page->currentTerminal(), Qt::Vertical)) { | |||
There was a problem hiding this comment.
I meant "convert canSplit to object function". So that, the way of calling it becomes
page->currentTerminal()->canSplit(Qt::Vertical)
src/views/termwidget.cpp
Outdated
| @@ -1011,6 +1011,38 @@ bool TermWidget::isInRemoteServer() | |||
| return false; | |||
| } | |||
|
|
|||
| bool TermWidget::canSplit(TermWidget *term, Qt::Orientation ori) { | |||
There was a problem hiding this comment.
I meant "convert canSplit to object function".
- change CanSplit to a public funtion of TermWidget - change MIN_WIDTH and MIN_HEIGHT of TermWidget to private
ArchieMeng
force-pushed
the
remove_split_count_limit
branch
from
f7d6de1 to
084e086
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ArchieMeng, hualet The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
mhduiy
pushed a commit
to mhduiy/deepin-terminal
that referenced
this pull request
Oct 22, 2024
* feat: remove the limit of term splitting a feature request from here: https://bbs.deepin.org/post/277237 * fix: no term gets focus after closing one fix no term gets focus after closing one, which will cause crashes if you hit Alt+Q in sequence. * fix: change minimum size set on TermWidget original minimum size relies on the limit of one can only split the terminal once, since we removed the limits, the minimum size should change accordingly * fix: new term not showing in the right position fix the bug that new term not showing right after the old one after the splitting * fix: new term resized wrongly fix the bug that new term has wrong size after splitting * fix: disable splitting menu if there's no room disable splitting menu when there's no enough room for splitting * fix: shortcut can still do splitting on room left fix shortcut still work even when there's no room for splitting * fix: crash of unfound size createSubSplit has side effects, it removes the term form its parent, so find size of it in QSplitter::sizes crashes. * chore: some code refactory - change CanSplit to a public funtion of TermWidget - change MIN_WIDTH and MIN_HEIGHT of TermWidget to private
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a feature request from here: https://bbs.deepin.org/post/277237