Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: build version support #422

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

kegechen
Copy link
Contributor

qt_add_qml_module VERSION 不支持 4 位版本号

deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Nov 25, 2024
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#422
qt_add_qml_module VERSION 不支持 4 位版本号, 暂时固定 1.0
@deepin-ci-robot
Copy link
Contributor

deepin pr auto review

关键摘要:

  • VERSION 固定为 "1.0" 可能会导致版本控制问题,建议使用变量或配置文件来管理版本号。
  • 检查是否有其他地方也使用了硬编码的版本号,以保持一致性。

是否建议立即修改:

  • 是,建议立即修改版本号的管理方式,以避免潜在的版本控制问题。

deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Dec 2, 2024
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#422
@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, kegechen

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kegechen kegechen merged commit 64ccb91 into linuxdeepin:master Dec 2, 2024
19 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants