Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ColorSelector can't read builtin property firstly in qt6.8 #427

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

18202781743
Copy link
Contributor

Remove cached in qt6.8.

pms: BUG-289241

@deepin-ci-robot
Copy link
Contributor

deepin pr auto review

关键摘要:

  • ensureMetaObject函数中,m_metaObject->setCached(true);的注释提到了在QML中可能会导致内置属性未定义,但未提供解决方案。
  • 条件编译指令#if QT_VERSION <= QT_VERSION_CHECK(6, 8, 0)可能限制了代码的兼容性,建议评估是否有必要使用条件编译,或者是否有更通用的解决方案。

是否建议立即修改:

  • 是,建议立即解决注释中提到的问题,并考虑是否有更通用的解决方案来避免条件编译。

deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Dec 3, 2024
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#427
@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, FeiWang1119

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@18202781743 18202781743 merged commit c3f4491 into linuxdeepin:master Dec 3, 2024
19 of 21 checks passed
18202781743 pushed a commit to linuxdeepin/dtk6declarative that referenced this pull request Dec 3, 2024
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#427
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants