Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

script logic overrides code-server sub-sub domains #769

Closed
drizuid opened this issue Sep 26, 2023 · 1 comment
Closed

script logic overrides code-server sub-sub domains #769

drizuid opened this issue Sep 26, 2023 · 1 comment
Assignees

Comments

@drizuid
Copy link
Member

drizuid commented Sep 26, 2023

ref: https://discord.com/channels/354974912613449730/1156192693655961630

https://github.com/linuxserver/docker-mods/blob/swag-auto-proxy/root/app/auto-proxy.sh#L70C21-L70C21
the lines above will take something like 5000.code-server.mydomain.com and rewrite it to code-server.mydomain.com which breaks code-server functionality.

I think fixing this would be a lot of work, so we should specifically exclude it from the scope of auto proxy in the readme for both code-server and swag, IMO.

@aptalca
Copy link
Member

aptalca commented Sep 26, 2023

That var overrides the server_name directive in the proxy conf. If the directive is set to a regex in the proxy conf, but the user sets it to 5000.code-server.mydomain.com, they are bypassing the regex, but it's not a bug because the mod is doing exactly what the user told it to do.

The var can accept regex values (as well as multiple server names), however, so the user can set it to code-server.blah.com "~^[0-9]{1,10}\.code-server\.blah.com"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants