Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] make AppImage to work by default #261

Closed
1 task done
tomaszduda23 opened this issue Sep 20, 2024 · 9 comments
Closed
1 task done

[FEAT] make AppImage to work by default #261

tomaszduda23 opened this issue Sep 20, 2024 · 9 comments
Labels
enhancement New feature or request

Comments

@tomaszduda23
Copy link
Contributor

Is this a new feature request?

  • I have searched the existing issues

Wanted change

add libfuse2 by default to let AppImage mount file system

Reason for change

many apps is distributed as AppImage

Proposed code change

apt install libfuse2

@tomaszduda23 tomaszduda23 added the enhancement New feature or request label Sep 20, 2024
Copy link

Thanks for opening your first issue here! Be sure to follow the relevant issue templates, or risk having this issue marked as invalid.

@thelamer
Copy link
Member

What about /dev/fuse? And how do you run mount inside of the container.
This is not just missing package, it is about privving the container way up.

@tomaszduda23
Copy link
Contributor Author

tomaszduda23 commented Sep 20, 2024

It requires following settings. It could be mentioned in documentation.

    cap_add:
      - SYS_ADMIN
    security_opt:
      - apparmor:unconfined
    devices:
      - /dev/fuse:/dev/fuse

@thelamer
Copy link
Member

This is basically privileged without all of sys and dev being mounted in, also app images can run in containers with the --appimage-extract-and-run flag.
On top of that people can expand the native known working app catalogue with https://github.com/linuxserver/proot-apps, many of these apps are uncompressed app images.
I am not going to recommend to people that they run in priv mode to run an appimage.

@tomaszduda23
Copy link
Contributor Author

It is an user choice if they prefer convenience or security. I just asked to add extra package.

Looking on this request again... There will be more users which needs extra package for their use cases. I would like to have gdb also due to kasmtech/KasmVNC#204 (comment).
Would you consider to support package install during container start by env variable? E.g.: ADD_EXTRA_PACKAGES: libfuse2 gdb.

If someone need one or two packages they usually don't want to bother with building custom image and updating it each time.

@Roxedus
Copy link
Member

Roxedus commented Sep 20, 2024

Would you consider to support package install during container start by env variable?

https://github.com/linuxserver/docker-mods/tree/universal-package-install

@tomaszduda23
Copy link
Contributor Author

https://github.com/linuxserver/docker-mods/tree/universal-package-install

Awesome. It would be worth to mentioned it explicit in documentation next too PRoot Apps.

@aptalca
Copy link
Member

aptalca commented Sep 20, 2024

@tomaszduda23
Copy link
Contributor Author

tomaszduda23 commented Sep 21, 2024

https://github.com/linuxserver/docker-webtop?tab=readme-ov-file#docker-mods

It is very hard to understand the meaning of this for someone who had no idea that there is such possibility. I added PR which makes it clear. You might consider to merge it. #262

@tomaszduda23 tomaszduda23 closed this as not planned Won't fix, can't repro, duplicate, stale Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

No branches or pull requests

4 participants