Deleting a DatafactoryType with zero items blocks other DatafactoryTypes from being deleted

[Zarimax]

We noticed a behavior in the "delete ADF items" task that seems a little odd.

We have an ADF resource with these contents:

- 0 Triggers
- 130 Pipelines
- 0 Data flows
- 30 Datasets
- 30 Linked Services

We tried running a "delete ADF items" task with these parameters:

- ServiceFilter: *
- DataflowFilter: *
- DatasetFilter: *
- PipelineFilter: *
- TriggerFilter: *
- Sorting: descending
- continue: false
- Throttle: 5
- detectDependancy: true

Our goal was to clear the ADF resource of all contents, regardless of the DatafactoryType. To accomplish this, we used * wildcards for all filters.

The odd behavior that we noticed is this: the task runs, but it reports that zero Triggers were found and it immediately finishes as successful. The expected deletions of the Pipeline, Dataset, and Linked Service items did not occur.

There was no error or warning - the task just finishes after finding zero Triggers to delete.

We can get around this issue by leaving the Trigger and Data Flow filters blank, but that would prevent us from globally applying this task to any ADF resource, (regardless of its contents). We would either need to be aware of the contents of the ADF resource first, (to set only the correct filters to the * wildcard), or we would need 5 separate copies of this task, (one for each * wildcard filter).

I don't know TypeScript, but maybe this behavior is caused by the combination of this Promise.all:

vsts-publish-adf/delete-adf-items/v2/deleteadfitems.ts

Line 387 in a211131

Promise.all(

and this item map, when the array of items is empty?

vsts-publish-adf/delete-adf-items/v2/deleteadfitems.ts

Line 196 in a211131

items.map((item: ADFJson) => {

Would it make sense to treat (items.length === 0) like a resolved promise here, similar to this code?

vsts-publish-adf/delete-adf-items/v2/deleteadfitems.ts

Line 374 in a211131

if (items.length === 0) return Promise.resolve(true);

[liprec]

Thanks for the feedback and I will look at your suggestion.

[shay2501]

I have noticed this behavior as well. Unfortunately it makes the extension unusable to me. I will try the extension again once this gets fixed. It works well otherwise!