Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Delete follow-up: metadata and options #2533

Merged
merged 7 commits into from
Aug 15, 2016
Merged

Delete follow-up: metadata and options #2533

merged 7 commits into from
Aug 15, 2016

Conversation

2e2a
Copy link
Contributor

@2e2a 2e2a commented Jul 21, 2016 •
edited
Loading

See #2374

  • remove 'deleted field in IMetadata sheet in backend
  • remove special 'hidden' field for metadatda sheet in options requests (not needed anymore)

@2e2a 2e2a added the frontend label Jul 27, 2016
@2e2a
Copy link
Contributor Author

2e2a commented Jul 27, 2016

@xi, @der-john:
As the hidden/deleted differentiation is obsolete, the flags are removed from the IMetadata sheet in the options request (See deletion.rst). This requires a frontend adaptation.

@2e2a 2e2a changed the title Delete follow-up Delete follow-up: metadata and options Jul 27, 2016
@2e2a 2e2a removed the incomplete label Jul 28, 2016
@der-john der-john self-assigned this Aug 4, 2016
@der-john
Copy link

der-john commented Aug 4, 2016

I'm a little out of my depth here: I can see no occurrences of "deleted" in the frontend anymore. And deleting comments works perfectly fine. But the options request for hide seems to return false all the time, even for god. Some part of the Http module probably needs adaption, but I don't which right now.

@der-john der-john removed their assignment Aug 4, 2016
@joka joka added the incomplete label Aug 9, 2016
joka
joka reviewed Aug 9, 2016
View reviewed changes
src/adhocracy_core/docs/deletion.html
</div>
</div>
</body>
</html>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this html file does not belong here

@joka
Copy link
Collaborator

joka commented Aug 9, 2016

yeah, less code, backend looks good

@2e2a 2e2a removed the incomplete label Aug 15, 2016
@2e2a
Copy link
Contributor Author

2e2a commented Aug 15, 2016

tested frontend adaptation

@2e2a 2e2a merged commit bdb92b5 into master Aug 15, 2016
@joka joka deleted the 2016-07-as-delete-follow-up branch April 12, 2018 11:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
backend frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@2e2a @der-john @joka