Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit reviews to unreviewed values. #75

Open
1 task
zanerock opened this issue Dec 8, 2023 · 0 comments
Open
1 task

Limit reviews to unreviewed values. #75

zanerock opened this issue Dec 8, 2023 · 0 comments
Labels
bug Something is broken
Milestone

Comments

@zanerock
Copy link
Member

zanerock commented Dec 8, 2023

Overview

Given something like the following:

{  "actions": [
  { "prompt": "What's your favorite number?", "parameter": "FAV_NUMBER", "paramType": "int" },
  { "review": "all" },
  { "maps": [ { "source": "FAV_NUMBER >= 100", "parameter": "BIG_NUMBER", "parameterType": "bool" }},
  { "review": "all" }
]}

Our goal (and documentation) would be that only "BIG_NUMBER" is reviewed in the second review since "FAV_NUMBER" was reviewed in the first and reviews should only include "not already reviewed" values.

Deliverables

  • implement the "not already reviewed" logic of review actions
@zanerock zanerock added the bug Something is broken label Dec 8, 2023
@zanerock zanerock added this to the 1.0.0-beta milestone Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken
Projects
None yet
Development

No branches or pull requests

1 participant