Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix new table bucketing during unserialization #930

Open
luojiuuuuu opened this issue Dec 5, 2023 · 0 comments
Open

Fix new table bucketing during unserialization #930

luojiuuuuu opened this issue Dec 5, 2023 · 0 comments

Comments

@luojiuuuuu
Copy link

luojiuuuuu commented Dec 5, 2023

Issue: Anyone upgrading will have a lot of their new table data lost, even if they're not using an asmap.

Expect behavior: We unnecessarily rebucket when reading a peers.dat.

Actual behavior: The code currently rebuckets entries (losing the additional bucket positions) if the asmap checksum changes.

For specific information please refer to the bitcoin project bug issue bitcoin#20557, I found the same bug code in litecoin which has not been fixed yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant